Adds a persistent Sandbox for evaluating code#2
Open
sukima wants to merge 4 commits intosr3d:masterfrom
sukima:feature/sandbox
Open
Adds a persistent Sandbox for evaluating code#2sukima wants to merge 4 commits intosr3d:masterfrom sukima:feature/sandbox
sukima wants to merge 4 commits intosr3d:masterfrom
sukima:feature/sandbox
Conversation
Uses a custom sandbox object to attach a context for any code being executed. This sandbox will store a JS context between eval executions. It prevent global name space pollution. Adds ability to send non JavaScript commands such as `/reset` (Only command supported so far). Reset command will create a new sandbox environment and garbage collect the last one.
This should probubly NOT be in the repo. Shouldn't we gitignore these build files?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses a custom sandbox object to attach a context for any code being executed. This sandbox will store a JS context between eval executions. It prevent global name space pollution.
Adds ability to send non JavaScript commands such as
/reset(Only command supported so far).Reset command will create a new sandbox environment and garbage collect the last one.
Shouldn't we gitignore the build files in
dist/?