Remove slideback timer when the component is unmounted#11
Open
anttimann wants to merge 1 commit intosreejithr:masterfrom
Open
Remove slideback timer when the component is unmounted#11anttimann wants to merge 1 commit intosreejithr:masterfrom
anttimann wants to merge 1 commit intosreejithr:masterfrom
Conversation
…ut has been triggered.
Owner
|
Thank you for fixing this. This has been a huge issue. I'll merge it after a round of testing. Btw, @anttimann, we need some testcases to be run before a merge. I'm planning to take it up on a free weekend. But you're always welcome to contribute :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove slideback timer when the component is unmounted before the timeout has been triggered otherwise timeout is triggered when component is already unmounted.
#10