Direction of the slide for BOTH directions and issue is this.props.successfulSlidePercent for slide direction calculation and slideback control option #18
Open
shanakaf wants to merge 3 commits intosreejithr:masterfrom
shanakaf:master
Open
Direction of the slide for BOTH directions and issue is this.props.successfulSlidePercent for slide direction calculation and slideback control option #18shanakaf wants to merge 3 commits intosreejithr:masterfrom shanakaf:master
shanakaf wants to merge 3 commits intosreejithr:masterfrom
shanakaf:master
Conversation
-Direction of the button slided by user. Useful when using `SlideDirection.BOTH` *Bug Fixes - Fixed the issue in not using the this.props.successfulSlidePercent for calculating the slide movement
slideBackToOriginal option is added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Features
-Direction of the button slided by user. Useful when using SlideDirection.BOTH
-slideBackToOriginal is added to check whether to slide back the button back to it's original position after 1 second
*Bug Fixes
-Fixed the issue in not using the this.props.successfulSlidePercent for calculating the slide movement