Start stop nodes

[FloSch62]

The start/stop/restart command starts/stops/restarts one or more nodes in a deployed lab and restores parked dataplane
interfaces

Tested:

• nokia_srl
• nokia_srsim (standalone and distributed)
• nokia_sros
• juniper_vmx

[steiler]

just a couple of comments

[FloSch62]

vxlan tests fail, because of #3056

[FloSch62]

For srsim distributed, I may would need some help from you @kaelemc and @sacckth , but imho that can also be added later.

[FloSch62]

@kaelemc and @steiler I tried to drive this further. Feel free to revert the last commit if you had other plans or if its not satisfying to you

[codecov]

Codecov Report

❌ Patch coverage is 48.33703% with 233 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.42%. Comparing base (fb0bcf1) to head (f1be230).
⚠️ Report is 33 commits behind head on main.

Files with missing lines	Patch %	Lines
nodes/vr_node.go	0.00%	70 Missing ⚠️
nodes/default_node.go	40.62%	28 Missing and 10 partials ⚠️
nodes/sros/sros.go	26.92%	19 Missing ⚠️
mocks/mocknodes/node.go	0.00%	16 Missing ⚠️
links/parking_node.go	70.83%	8 Missing and 6 partials ⚠️
runtime/podman/podman.go	0.00%	12 Missing ⚠️
utils/netlink.go	67.56%	10 Missing and 2 partials ⚠️
core/restart.go	33.33%	4 Missing and 4 partials ⚠️
mocks/mocknodes/default_node.go	0.00%	8 Missing ⚠️
core/lifecycle.go	68.42%	3 Missing and 3 partials ⚠️
... and 7 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3055      +/-   ##
==========================================
- Coverage   56.92%   56.42%   -0.50%     
==========================================
  Files         216      224       +8     
  Lines       21469    22019     +550     
==========================================
+ Hits        12221    12425     +204     
- Misses       8003     8304     +301     
- Partials     1245     1290      +45     

Files with missing lines	Coverage Δ
cmd/options.go	91.23% <100.00%> (+0.04%)	⬆️
cmd/root.go	81.06% <100.00%> (+2.44%)	⬆️
core/destroy.go	59.21% <100.00%> (+0.72%)	⬆️
nodes/ceos/ceos.go	64.10% <100.00%> (+0.18%)	⬆️
nodes/linux/linux.go	79.54% <100.00%> (+0.47%)	⬆️
nodes/node.go	21.42% <ø> (ø)
nodes/srl/srl.go	62.17% <100.00%> (+0.22%)	⬆️
runtime/runtime.go	63.82% <ø> (ø)
types/types.go	50.00% <ø> (ø)
runtime/docker/docker.go	66.94% <89.47%> (+0.93%)	⬆️
... and 16 more

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[sacckth]

stalled or what? @steiler @kaelemc @FloSch62

[kaelemc]

Yeah, stalled from my side. Discussed some stuff with Markus which I’ll try implement soon.

[FloSch62]

I tried to rework this so parking and endpoint ownership are handled in the node lifecycle, with the parking netns treated like a regular node and the same MoveTo flow used in both directions. So far I only tested this with srl; before I spend more time, are there any concerns with this direction @steiler @kaelemc ?