fix(core): handle exec errors and fix tool container cleanup loop#3159
Merged
hellt merged 1 commit intosrl-labs:mainfrom Apr 14, 2026
Merged
Conversation
exec.go: when RunExec fails with a non-ErrRunExecNotSupported error, the nil execResult was added to the collection, causing a panic on Log()/Dump(). Also use errors.Is instead of == for sentinel check. destroy.go: deleteToolContainers used return instead of continue in a loop over tool types. If sshx listing failed or found zero results, gotty containers were never cleaned up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes in core/:
exec.go: whenRunExecfails with a non-ErrRunExecNotSupportederror, the nilexecResultwas still added to the collection, causing a nil dereference panic onLog()/Dump(). Also switched toerrors.Isfor the sentinel check.destroy.go:deleteToolContainersusedreturninstead ofcontinuein a loop over tool types (["sshx", "gotty"]). If the sshx listing failed or found zero results, gotty containers were never cleaned up.Testing
go vet ./core/...— cleango test -race ./core/...— all pass