fix(core): close netns and netlink handles in ListContainerInterfaces#3161
Merged
hellt merged 1 commit intosrl-labs:mainfrom Apr 14, 2026
Merged
fix(core): close netns and netlink handles in ListContainerInterfaces#3161hellt merged 1 commit intosrl-labs:mainfrom
hellt merged 1 commit intosrl-labs:mainfrom
Conversation
netns.NsHandle wraps a file descriptor and netlink.Handle holds netlink sockets. Neither was closed after use, leaking resources on every call to inspect interfaces. With large labs this accumulates leaked file descriptors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
netns.NsHandle wraps a file descriptor and netlink.Handle holds netlink sockets. Neither was closed after use in ListContainerInterfaces, leaking resources on every call to
clab inspect interfaces.Added
defer .Close()for both handles, matching the pattern used incore/events/netlink.go.Testing
go vet ./core/...— cleango test -race ./core/...— all pass