Fix zero byte book produced by "polyglot make-book"#3
Open
selliott512 wants to merge 2 commits into
Open
Conversation
This reverts commit e5a9f1a. Revert this revert because it produces zero byte books when "polyglot make-book ..." is used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't quite understand the intent of the commit in question, but I do know that it breaks
polyglot make-bookin latest master, which means thatpolyglot make-bookis broken in at least Fedora 33.To reproduce:
which produces a 80 byte file with this fix, and zero byte otherwise. The problem has to do with entries incorrectly being filtered. Consider these two output lines in the 80 byte fixed case:
and in the zero byte broken case:
This merge request probably isn't suitable as is, but it's at least a starting point for people trying to figure out
polyglot make-bookon Linux.Also, I included a
.gitignore- all of the*.ofiles show up as untracked files otherwise.The
fools-mate.pgnmentioned above: