fix(evaluator): Honor inc-build flag in warmup prebuilds#207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inc_build_enabled=falseinc_build_enabledthrough dispatcher warmup, config-mode prebuild, and registration-backed prebuild so disabled configs prebuild clean variants rather than incremental-image workTesting
pytest -q tests/test_evaluator_warmup.py tests/test_registry.py tests/test_evaluator_dual_queue.py::TestRunEvaluatorMain::test_dispatcher_mode_keeps_warmup_when_inc_build_disabled tests/test_evaluator_dual_queue.py::TestConfiglessEvaluator::test_enqueue_pre_builds_from_registration_propagates_inc_image_settings tests/test_evaluator_dual_queue.py::TestConfiglessEvaluator::test_enqueue_pre_builds_from_registration_honors_inc_build_disabled tests/test_evaluator_dual_queue.py::TestConfiglessEvaluator::test_enqueue_pre_builds_propagates_inc_image_settings tests/test_evaluator_dual_queue.py::TestConfiglessEvaluator::test_enqueue_pre_builds_honors_inc_build_disabledscripts/ci-tests/run-local.sh checksNotes
inc_build_enabledis off