feat(reeval): cap per-trial POVs and add reeval merge script#211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CRSBENCH_REEVAL_POV_SAMPLE_SIZE, default 100;0disables)._reeval_bug_finding) and async (_enqueue_trial_povs) verification paths so cloud workers see the same sampled subset.scripts/merge_reeval_into_source.pyto overlay a reeval result tree onto the source experiment tree with a surgicalpov_store.jsonmerge that preserves original CRS timing while adopting reeval verdicts.docs/design/distributed/cloud-reeval.mdto document the per-trial POV cap.tests/test_reeval.pycovering sampling/env parsing behavior.Description
Re-evaluation of large CRS runs was bottlenecked by trials with thousands of POVs. The cap enforces a deterministic per-trial budget by sorting POVs by mtime (a proxy for CRS discovery time), partitioning into equal time buckets, and randomly choosing one per bucket — seeded by the trial path so distributed workers agree on the subset. The merge script lets reeval results be folded back into the original experiment tree without losing original-run timing or downgrading POVs that reeval intentionally skipped (sampling) or never saw.
Commits:
d4e23bebfeat(reeval): cap per-trial POVs via stratified discovery-time sampling05e4c563chore(reeval): lower default POV sample cap to 1008b3068dbfeat: add reeval merge script