fix(adapter): Record oss-crs timing per trial#216
Merged
Conversation
Preserve explicit work_dir reuse without leaking cached build state across trial or work_dir boundaries. Also record build_time as build wall-clock minus lock wait and keep staged benchmarks available for resolve_artifacts when an explicit shared work_dir reuses an existing build.
Measure lock wait inside _acquire_lock() so build_time excludes only actual flock contention rather than uncontended lock helper overhead. Add direct helper coverage and keep the higher-level build_time regression test aligned with the real lock-wait contract.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_time/build_timeasnull.work_dir, including restaging benchmarks for artifact resolution when a shared explicit workdir is reused.flock()contention only, with regression coverage for timing and reuse paths.Testing
pytest -q tests/test_compose_adapter.pyscripts/ci-tests/run-local.sh checksNotes