Open
Conversation
Owner
|
Would it be possible to rewrite this to do checks rather than rely on exception handling? |
Author
|
Ofcourse we could do My original question still stands however. Is this a good idea in the first place? I.e. is this a malformed xlsx document or should we perhaps be looking at a different location in the xml? I don't have in-depth knowledge of the used xml format, so I don't know which is the case here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reading a rather complex excel file (that I can't share due to NDA) I ran into an IndexError on an inlineStr node. I have no idea what that means exactly, thus the current work around.
Do you have any comments on whether this is a good idea?