require owner signature for shutdown and strategy execution#39
Open
mooncitydev wants to merge 1 commit into
Open
require owner signature for shutdown and strategy execution#39mooncitydev wants to merge 1 commit into
mooncitydev wants to merge 1 commit into
Conversation
close permissionless paths on stable and weighted shutdown, and lock stable strategy execution to the pool owner so third parties cannot trigger sensitive state changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
shutdownaccount constraints to requireowneras a signer, removing a permissionless path that could close pool stateexec_strategyto requireowner: Signerandpoolownership, so only pool owner can trigger amp ramp updatesexecStrategyaccount mapping to includeownerfor compatibility with the on-chain auth fixtest plan
cargo check(blocked in this windows environment by linker/toolchain setup:link.exeargument handling issue before crate compilation completes)ReadLintson edited files reports no diagnostics