Fix Octavia certificates generation docs#2401
Conversation
cityofships
added
documentation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Octavia documentation to ensure the target directory is created before copying certificates, and corrects the source paths for the server CA certificate and key from 'client_ca' to 'server_ca'. The reviewer noted that this same path error is present in the 'Rotating the CAs' section of the document and should also be corrected.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| cp $KOLLA_CONFIG_PATH/octavia-certificates/server_ca/server_ca.cert.pem . | ||
| cp $KOLLA_CONFIG_PATH/octavia-certificates/server_ca/server_ca.key.pem . |
There was a problem hiding this comment.
The same issue with incorrect paths for server_ca.cert.pem and server_ca.key.pem (using client_ca instead of server_ca) also exists in the Rotating the CAs section on lines 203-204. Please apply the same fix there to ensure consistency and correctness.
There was a problem hiding this comment.
Gemini is correct, there's another instance of this further down the file
| cp $KOLLA_CONFIG_PATH/octavia-certificates/server_ca/server_ca.cert.pem . | ||
| cp $KOLLA_CONFIG_PATH/octavia-certificates/server_ca/server_ca.key.pem . |
There was a problem hiding this comment.
Gemini is correct, there's another instance of this further down the file
github-actions
Bot
added
waiting-author-response
2 participants
No description provided.