You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For this SIP, I would ask "why"? I definitely agree that a standard for metadata is necessary. However, why should we keep it on-chain?
One reason to keep it on-chain is so that other contracts can consume this information. But, for metadata, why do they need to? Would an external contract ever need to do some logic based on this contract's mime-type, or image-url? Perhaps there is a registry for only JPEG NFTs. But, in that case, you cannot guarantee that the actual type of the image is JPEG - that's just what the contract says.
Another reason might be to provide some guarantee as a client that the information returned from an HTTP request to get-token-uri is not changing, or is not returning different data to different clients. In that case, storing the hash of the result of that HTTP request would be sufficient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR