Conversation
There was a problem hiding this comment.
Pull request overview
This PR represents a complete rewrite of TISE (Terra Invicta Save Editor) from Python to Rust, introducing significant architectural improvements and new features.
Changes:
- Complete rewrite from Python/tkinter to Rust/egui with a modern cross-platform GUI
- New features: search functionality, reference browser, undo/redo support, and comprehensive test suite
- Improved save file handling with byte-for-byte round-trip guarantees and line ending preservation
Reviewed changes
Copilot reviewed 28 out of 41 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tise/statics.py | Removed Python constants file |
| tise/app.py | Removed Python application logic |
| tise/init.py | Removed Python module initialization |
| pyproject.toml | Removed Poetry configuration |
| pyinstaller.spec | Removed PyInstaller build specification |
| poetry.lock | Removed Poetry lockfile |
| src/lib.rs | New Rust library entry point |
| src/main.rs | New Rust application entry point |
| src/statics.rs | New Rust constants and UI strings |
| src/value.rs | New JSON5 value types with Terra Invicta serialization |
| src/save.rs | New save file loading/parsing/indexing logic |
| src/gui.rs | New egui-based GUI implementation with all features |
| tests/roundtrip.rs | New byte-for-byte roundtrip tests |
| tests/mutation.rs | New mutation and dirty-flag tests |
| tests/line_endings.rs | New line ending preservation tests |
| tests/indexing.rs | New save indexing tests |
| Cargo.toml | New Rust package configuration |
| rust-toolchain.toml | New Rust toolchain specification |
| README.md | Updated documentation for Rust version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TISE 2.0