Expose the reload decision API in a public package (v2)#1191
Open
msafwankarim wants to merge 10 commits into
Open
Expose the reload decision API in a public package (v2)#1191msafwankarim wants to merge 10 commits into
msafwankarim wants to merge 10 commits into
Conversation
✅ Load Test Results (quick)✅ Load Test Results: ALL TESTS PASSED
3/3 passed (100%)
Artifacts: Download |
✅ Load Test Results (quick)✅ Load Test Results: ALL TESTS PASSED
3/3 passed (100%)
Artifacts: Download |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes the config, metadata, and annotation-decision types to public packages (pkg/) so a separate Go module can consume them, while keeping the workload-coupled reload engine internal. External consumers can now import the decision logic without pulling in internal/-only types.
What's public now
pkg/matcherthe decision API: Matcher, NewMatcher, MatchInput, MatchResult, ResourceType (+ constants). Depends only on pkg/config; imports nothing from internal/.pkg/config: configuration types (Config, annotations, validation, selectors).pkg/metadata: build/deployment metadata + ConfigMap publisher.Notes:
pkg/configandpkg/metadatado import internal/pkg/workload for an implementation-detail constant/helper, but never expose internal types in their signatures, so they remain usable externally.