fix(ci): remove redundant binary rename step for Unix builds#5
Open
fix(ci): remove redundant binary rename step for Unix builds#5
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a build failure in the release workflow for Unix platforms (Linux and macOS) where the binary rename step was attempting to rename files to their existing names, causing the mv command to fail with "source and destination are the same file" error.
Changes:
- Removed redundant Unix binary rename step from release workflow
- Bumped package version from 1.1.0 to 1.1.1
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/release.yml | Removed the redundant Unix binary rename step that was causing the build to fail |
| package.json | Bumped patch version to reflect the bug fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the release workflow failing on Linux with:
Problem
The
build-sea.jsscript already names Unix binaries with platform and architecture (e.g.,shield-linux-x64,shield-darwin-arm64). The subsequent rename step tried to rename them to the same name, causing themvcommand to fail.Solution
Remove the redundant rename step for Unix platforms. The Windows rename step is kept because
build-sea.jscreatesshield.exe(generic name) which needs to be renamed toshield-windows-x64.exe.Testing
build-sea.jscreates correctly-named binaries