Skip to content

fix(ci): remove redundant binary rename step for Unix builds#5

Open
ajag408 wants to merge 1 commit intomainfrom
fix/release-workflow-rename
Open

fix(ci): remove redundant binary rename step for Unix builds#5
ajag408 wants to merge 1 commit intomainfrom
fix/release-workflow-rename

Conversation

@ajag408
Copy link
Contributor

@ajag408 ajag408 commented Feb 5, 2026

Summary

Fixes the release workflow failing on Linux with:

mv: 'shield-linux-x64' and 'shield-linux-x64' are the same file

Problem

The build-sea.js script already names Unix binaries with platform and architecture (e.g., shield-linux-x64, shield-darwin-arm64). The subsequent rename step tried to rename them to the same name, causing the mv command to fail.

Solution

Remove the redundant rename step for Unix platforms. The Windows rename step is kept because build-sea.js creates shield.exe (generic name) which needs to be renamed to shield-windows-x64.exe.

Testing

  • Local binary build on macOS confirmed build-sea.js creates correctly-named binaries

Copilot AI review requested due to automatic review settings February 5, 2026 03:15
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a build failure in the release workflow for Unix platforms (Linux and macOS) where the binary rename step was attempting to rename files to their existing names, causing the mv command to fail with "source and destination are the same file" error.

Changes:

  • Removed redundant Unix binary rename step from release workflow
  • Bumped package version from 1.1.0 to 1.1.1

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/release.yml Removed the redundant Unix binary rename step that was causing the build to fail
package.json Bumped patch version to reflect the bug fix

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant