Conversation
Update packages
Add registration via keystore
# Conflicts: # src/validators/endpoints.py # src/validators/validators.py
Keystore funding
Update validator type
Update funding, remove keystore
There was a problem hiding this comment.
Pull Request Overview
This PR implements version 4 of the validator management system, adding support for flexible validator funding amounts and multiple validator operation types (funding, withdrawal, consolidation). The key changes include introducing validator types (V1/V2), replacing fixed deposit amounts with configurable amounts per validator, and adding new API endpoints for different validator operations.
- Added support for V1 and V2 validator types with different withdrawal credential mechanisms
- Replaced fixed 32 ETH deposits with configurable amounts per validator
- Added new API endpoints for funding, withdrawal, and consolidation operations alongside the existing register endpoint
Reviewed Changes
Copilot reviewed 17 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/validators/validators_manager.py | Split signature generation into operation-specific functions and updated encoding logic for validator types |
| src/validators/validators.py | Updated validator generation to accept amounts and validator types instead of fixed parameters |
| src/validators/typings.py | Added ValidatorType enum and updated Validator dataclass with flexible amount field |
| src/validators/schema.py | Added new request/response models for different validator operations |
| src/validators/endpoints.py | Added new endpoints for fund, withdraw, and consolidate operations |
| src/validators/credentials.py | Updated credential generation to support V1/V2 validator types and flexible amounts |
| src/config/networks.py | Simplified network constants by importing from sw_utils |
| src/common/schema.py | Added InfoResponse model for network information |
| src/common/endpoints.py | Added info endpoint for network information |
| src/common/contracts.py | Updated ContractWrapper to support dynamic addresses and added VaultContract |
| src/common/app_state.py | Moved AppState class from validators module to common module |
| src/common/abi/IEthVault.json | Added vault contract ABI for validator operations |
| src/app.py | Updated imports and added info router |
| pyproject.toml | Updated Python version and dependencies |
| Dockerfile | Updated Python base image |
| .pre-commit-config.yaml | Added vulture for dead code detection |
| .github/workflows/ci.yaml | Updated Python version in CI |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
tsudmi
approved these changes
Sep 29, 2025
evgeny-stakewise
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.