Merged
Conversation
# Conflicts: # src/validators/endpoints.py # src/validators/validators.py
There was a problem hiding this comment.
Pull Request Overview
This pull request adds keystore funding functionality to the validators system by implementing new signature methods and endpoints for funding, withdrawal, and consolidation operations.
- Refactored signature generation to support different validator operations (register, fund, withdraw, consolidate)
- Added new API endpoints for funding, withdrawal, and consolidation of validators with appropriate signatures
- Introduced VaultContract wrapper class and added support for validator manager nonce
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/validators/validators_manager.py | Refactored signature generation into operation-specific functions and added encoding functions |
| src/validators/validators.py | Added function to generate validators for funding operations |
| src/validators/typings.py | Made validator fields optional with default values |
| src/validators/schema.py | Added request/response models for funding, withdrawal, and consolidation operations |
| src/validators/endpoints.py | Added new API endpoints for fund, withdraw, and consolidate operations |
| src/common/contracts.py | Refactored contract wrapper to support dynamic addresses and added VaultContract class |
| src/common/abi/IEthVault.json | Added ABI definition for the Ethereum vault contract |
| pyproject.toml | Updated vulture ignore list to include new API endpoint function names |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
tsudmi
approved these changes
Sep 16, 2025
evgeny-stakewise
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.