Open
Conversation
There was a problem hiding this comment.
Pull request overview
Reworks the osToken redemption multiplier representation to use an integer basis-points (bps) field while keeping a derived Decimal multiplier available via a property on ProtocolConfig.
Changes:
- Replace
os_token_redeem_multiplier: Decimalwithos_token_redeem_multiplier_bps: intand add a computedos_token_redeem_multiplierproperty. - Update protocol config building and test factories to use the new
_bpsfield/key and default. - Bump package version and extend
.gitignore.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
sw_utils/typings.py |
Renames multiplier field to bps and adds a computed Decimal property. |
sw_utils/protocol_config.py |
Reads multiplier from os_token_redeem_multiplier_bps config key and passes into ProtocolConfig. |
sw_utils/tests/factories.py |
Updates test factory defaults and construction to the new bps field. |
pyproject.toml |
Version bump v0.12.9 → v0.12.10. |
.gitignore |
Ignores CLAUDE.md and .claude. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.