Fix missing redemption assets arg#670
Merged
evgeny-stakewise merged 1 commit intov5-releasefrom Feb 26, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where redemption assets were not being properly passed as a parameter to the smart contract's getExitQueueMissingAssets function. Instead, they were incorrectly being added to the result after the contract call, which could lead to inaccurate exit queue calculations.
Changes:
- Fixed the flow to pass
redemption_assetsas a parameter to the smart contract call instead of adding it to the result afterwards - Updated the return type of
get_redemption_assetsfromGweitoWeifor consistency with contract parameters - Updated the smart contract ABI to include the new
redemptionAssetsparameter
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/withdrawals/tasks.py | Moved redemption assets calculation before get_queued_assets call and passed it as a parameter; cleaned up imports |
| src/withdrawals/assets.py | Added redemption_assets parameter to get_queued_assets function and passed it to the contract call |
| src/redemptions/tasks.py | Changed return type from Gwei to Wei and removed GNO-to-mGNO conversion logic (now returns GNO-Wei directly) |
| src/common/typings.py | Added redemption_assets field to ExitQueueMissingAssetsParams dataclass |
| src/common/contracts.py | Updated contract call to include redemption_assets parameter |
| src/common/abi/IValidatorsChecker.json | Updated ABI to reflect the new redemptionAssets parameter in getExitQueueMissingAssets function |
Comments suppressed due to low confidence (1)
src/withdrawals/assets.py:52
- The docstring should be updated to document the new
redemption_assetsparameter. It should describe what redemption assets represent and note that for GNO networks, this value should be in GNO-Wei units to maintain consistency with thewithdrawing_assetsparameter handling.
"""
Get exit queue missing assets.
For Gno networks return value in mGNO-Gwei.
"""
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cyc60
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.