Skip to content

Fix missing redemption assets arg#670

Merged
evgeny-stakewise merged 1 commit intov5-releasefrom
fix-redemption-assets-arg
Feb 26, 2026
Merged

Fix missing redemption assets arg#670
evgeny-stakewise merged 1 commit intov5-releasefrom
fix-redemption-assets-arg

Conversation

@evgeny-stakewise
Copy link
Contributor

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where redemption assets were not being properly passed as a parameter to the smart contract's getExitQueueMissingAssets function. Instead, they were incorrectly being added to the result after the contract call, which could lead to inaccurate exit queue calculations.

Changes:

  • Fixed the flow to pass redemption_assets as a parameter to the smart contract call instead of adding it to the result afterwards
  • Updated the return type of get_redemption_assets from Gwei to Wei for consistency with contract parameters
  • Updated the smart contract ABI to include the new redemptionAssets parameter

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/withdrawals/tasks.py Moved redemption assets calculation before get_queued_assets call and passed it as a parameter; cleaned up imports
src/withdrawals/assets.py Added redemption_assets parameter to get_queued_assets function and passed it to the contract call
src/redemptions/tasks.py Changed return type from Gwei to Wei and removed GNO-to-mGNO conversion logic (now returns GNO-Wei directly)
src/common/typings.py Added redemption_assets field to ExitQueueMissingAssetsParams dataclass
src/common/contracts.py Updated contract call to include redemption_assets parameter
src/common/abi/IValidatorsChecker.json Updated ABI to reflect the new redemptionAssets parameter in getExitQueueMissingAssets function
Comments suppressed due to low confidence (1)

src/withdrawals/assets.py:52

  • The docstring should be updated to document the new redemption_assets parameter. It should describe what redemption assets represent and note that for GNO networks, this value should be in GNO-Wei units to maintain consistency with the withdrawing_assets parameter handling.
    """
    Get exit queue missing assets.
    For Gno networks return value in mGNO-Gwei.
    """

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@evgeny-stakewise evgeny-stakewise merged commit 636b642 into v5-release Feb 26, 2026
9 checks passed
@evgeny-stakewise evgeny-stakewise deleted the fix-redemption-assets-arg branch February 26, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants