Skip to content

Keep model_params to avoid breaking brms #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jgabry merged 2 commits into from
Mar 9, 2026
Merged

Keep model_params to avoid breaking brms #1152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18cb487
Keep model_params to avoid breaking brms
jgabry Mar 9, 2026
c27bc84
Update NEWS.md
jgabry Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
* Removed deprecated items (replacements in parentheses):
- `read_sample_csv()` (`read_cmdstan_csv()`)
- `write_stan_tempfile()` (`write_stan_file()`)
- `model_params` element of `fit$metadata()` list (`variables` element)
- `jacobian_adjustment` argument to `fit$log_prob()` and similar methods (`jacobian` argument)
- `output_samples` argument to `model$variational()` (`draws` argument)
- `hessian` argument to `fit$init_model_methods()` (`hessian` method always compiled now)
Expand Down
2 changes: 1 addition & 1 deletion R/csv.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ read_cmdstan_csv <- function(files,
model_param_dims <- variable_dims(metadata$variables)
metadata$stan_variable_sizes <- model_param_dims
metadata$stan_variables <- names(model_param_dims)

metadata$model_params <- metadata$variables # for backwards compatibility
if (metadata$method == "sample") {
if (is.null(format)) {
format <- "draws_array"
Expand Down
Loading