Get locking information for note and add GitHub action for automatic deploying#4
Get locking information for note and add GitHub action for automatic deploying#4MortalHappiness wants to merge 2 commits intostandardnotes:mainfrom
Conversation
|
Nice work! We do use yarn for everything in our repos so it would be ideal to stick with that. We can remove the engine requirements from the package.json file. I think it would also be better to update editor-kit with the version of the models package that you need, rather than overriding here, to make things simpler. |
|
@moughxyz Thank you! I'll update this PR to use yarn and remove the |
|
Done here standardnotes/app@5bfc608 |
|
Hi. I still get the following error message: |
|
The version of models with the removed engine requirement would have to be higher than the version it was in the fix commit, which was 1.47.8. |
|
@moughxyz Yes. I know the engine check has been removed in |
|
What about upgrading models package in editor kit? |
|
Yes. That's another solution. But actually, I think it will be better not to hard-code the dependency version. |

This PR does the following things:
gh-pagesbranch.Editor.tsxso that we can disable our editor if the note is locked. See the following video.standardnotes-template-screencast.mp4
I had a hard time figuring out how to implement the second feature because there is little documentation. I think other people will find this feature useful while implementing their own editor.
To achieve the second feature, there are a few changes:
@standardnotes/editor-kitto the latest version.@standardnotes/modelsversion to use the latest version, which is hard-coded in the dependencies for@standardnotes/editor-kit.yarn.lockand usenpminstead. We can also useyarnbut we need to useyarn install --ignore-enginesinstead, which is cumbersome. Ifyarnis needed, we must change theoverridesfield inpackage.jsontoresolutions. See https://stackoverflow.com/questions/40226639/how-do-i-override-nested-dependencies-with-yarn for details. But I think the better solution is not to hardcode@standardnotes/modelsversion in this file https://github.com/standardnotes/editor-kit/blob/c554d9f41423b9d4e8bfda847f541554d9aaf3d2/package.json