fix: dry-run correctness, verbose output gating, and CLI flag polish (v0.4.2)#16
Merged
Conversation
…de module removing in workspace clean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Continuation of #15 PR
Behavior changes
--verbose.node_modulesfor npm workspaces, tooaggressive/unprompted. May return later behind an explicit flag.
--cleanwas a silent no-op for npm projects; now warns under--verbose.CLI changes
--version.-v→--verbose,-bmoved from--build-typeto
--build,-padded for--profile.fixed
--builddoc comment not showing in--help.Fixes
build_projectcalled with swappedbuild_path/source_pathargs in mono mode.--no-dry-runconflicted with itself instead of--dry-run.--init-config/--profile-addreferences in help/error text.--build-systemwrote real config/wrap/watchfiles and spawned a real process instead of just reporting what would
happen.
--build-systemprinted "Projectfinished" instead of "Would finish".
(
--no-build, non-verbose), npm had no equivalent to cmake/meson's"Creating build directory" line to separate two independently-printed
section breaks.
Internal
configure_and_build(folded intobuild_project).path/mono_dir/build_dirinto sharedWorkspaceTarget.io_error_msganddetect_or_dry_runhelpers.dry_run_or_doto takeIoCtx/RunFlagsinstead of the fullRunCtx, so it can be reused by config/wrap/watch generators that don'thave a
Runner.generate_watch_scriptsreturnsboolso watch scripts only open when generated.run()# Errorsdoc.