feat: prompt before overwriting existing or invalid repos during batch clone#17
Merged
Conversation
…ame clone_repository to clone_repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mono/batch cloning previously silently skipped any repo directory that already
existed on disk, no update, no prompt, regardless of
--yes, and didn'tdistinguish a real git repo from a stale/invalid leftover directory. This adds:
a/sshortcuts (update-all / skip-all) once a batch reaches 5+ repos.
.git),with an explicit "remove and re-clone?" prompt. This destructive action is
never auto-confirmed by
--yes, destructive actions should be explicitly set.Also includes some structural cleanup: splitting
repository.rsandprompts.rsinto per-concern modules, replacingclone_repo'son_exists_skip/yesbool pair with a pluggableon_existscallback (so both single- and batch-clone modes can supply their own decision without duplicating the clone/pull mechanics).