refactor: default missing ConfigEntry fields and split flag resolution (v0.4.6)#20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Loading a config file that predates a field addition no longer fails, missing
ConfigEntryfields now fall back to defaults. Also splitsresolve_with_configinto per-group resolvers and dedupes test fixtures.Changes
ConfigEntrygets#[serde(default)]+ a manualDefaultimpl (with real"build"/"build-mono"dir defaults), so configs omitting any field load cleanly instead of erroringcreate_default_configand all test fixtures now build fromConfigEntry::default(), single source of truth, deleted thesample_entryfixtureresolve_with_configsplit intoresolve_connection_flags/resolve_run_flags/resolve_build_flags/resolve_mono_flags, plus the existingresolve_flag_pair, main fn is now just assembly