Add copying any shared lib, not only .so files#15
Open
Solpatium wants to merge 3 commits intostarkware-libs:masterfrom
Open
Add copying any shared lib, not only .so files#15Solpatium wants to merge 3 commits intostarkware-libs:masterfrom
Solpatium wants to merge 3 commits intostarkware-libs:masterfrom
Conversation
| ${CMAKE_COMMAND} -E copy | ||
| ${CMAKE_CURRENT_BINARY_DIR}/../libcrypto_c_exports.so | ||
| ${CMAKE_CURRENT_SOURCE_DIR}/libcrypto_c_exports.so | ||
| ${CMAKE_CURRENT_BINARY_DIR}/../libcrypto_c_exports.* |
Collaborator
There was a problem hiding this comment.
try:
libcrypto_c_exports${CMAKE_SHARED_LIBRARY_SUFFIX}
Also for the OUTPUT and DEPENDS line
Contributor
Author
|
Sorry for a late response, I was on vacation and then I was busy with something else :) |
ilyalesokhin-starkware
requested changes
Sep 12, 2022
Collaborator
ilyalesokhin-starkware
left a comment
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware and @Solpatium)
src/starkware/crypto/ffi/js/CMakeLists.txt line 2 at r2 (raw file):
add_custom_command( OUTPUT ${CMAKE_CURRENT_SOURCE_DIR}/libcrypto${CMAKE_SHARED_LIBRARY_SUFFIX}
Suggestion:
libcrypto_c_exports${CMAKE_SHARED_LIBRARY_SUFFIX}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #11. Makes it possible to copy .{so, dylib, dll} files