Skip to content

apollo_dashboard: extract shared exchange-rate oracle alert builders (#14702)#14762

Open
matanl-starkware wants to merge 1 commit into
main-v0.14.3from
matanl/bp-14702-oracle-alert-builders
Open

apollo_dashboard: extract shared exchange-rate oracle alert builders (#14702)#14762
matanl-starkware wants to merge 1 commit into
main-v0.14.3from
matanl/bp-14702-oracle-alert-builders

Conversation

@matanl-starkware

@matanl-starkware matanl-starkware commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Backport of #14702 to main-v0.14.3.

Clean git cherry-pick -x of f4c4a022f5. No starknet_version change (V0_14_3 preserved).

…14702)

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
(cherry picked from commit 3251ad1)
@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@matanl-starkware matanl-starkware marked this pull request as ready for review July 10, 2026 21:42
@cursor

cursor Bot commented Jul 10, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Alert-only refactor in apollo_dashboard with behavior preserved; no runtime or gas-price logic changes.

Overview
Moves ETH→STRK Grafana alert definitions out of alert_definitions.rs into l1_gas_prices.rs and factors shared Prometheus logic into oracle_success_count_alert and oracle_error_count_alert.

get_eth_to_strk_success_count_alert now delegates to the success helper (still sum_increase over 1h, fires when < 1 success). get_eth_to_strk_error_count_alert is re-exported from the L1 gas prices module and built via the error helper: sum_increase over 1h with or vector(0) so missing series do not cause no-data, threshold > 10 errors, 1m pending, Informational severity—matching the prior inline definition.

Reviewed by Cursor Bugbot for commit f4c4a02. Bugbot is set up for automated code reviews on this repo. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants