Skip to content

apollo_dashboard: add strk_to_usd oracle success and error alerts (#14703)#14763

Open
matanl-starkware wants to merge 1 commit into
matanl/bp-14702-oracle-alert-buildersfrom
matanl/bp-14703-strk-usd-oracle-alerts
Open

apollo_dashboard: add strk_to_usd oracle success and error alerts (#14703)#14763
matanl-starkware wants to merge 1 commit into
matanl/bp-14702-oracle-alert-buildersfrom
matanl/bp-14703-strk-usd-oracle-alerts

Conversation

@matanl-starkware

@matanl-starkware matanl-starkware commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Backport of #14703 to main-v0.14.3.

Clean git cherry-pick -x of ba478333bc. No starknet_version change (V0_14_3 preserved).

Stacked on matanl/bp-14702-oracle-alert-builders — merge that first.

Generated dev_grafana_alerts.json regenerated and verified identical (no-op).

…4703)

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
(cherry picked from commit 9e24339)
@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@matanl-starkware matanl-starkware marked this pull request as ready for review July 10, 2026 21:42
@cursor

cursor Bot commented Jul 10, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Observability-only dashboard alert definitions; no runtime gas-price or consensus logic changes.

Overview
Adds Grafana alerting for the SNIP35 STRK→USD oracle, parallel to the existing ETH→STRK oracle alerts.

New builders in l1_gas_prices.rs wire snip35_strk_usd_success_count and snip35_strk_usd_error_count through the shared oracle_success_count_alert / oracle_error_count_alert helpers (1h sum(increase), success < 1, errors > 10). Success severity uses a per-alert placeholder; errors are informational (p5 in dev JSON).

get_apollo_alerts() registers both alerts, and dev_grafana_alerts.json is updated with the corresponding rule definitions.

Reviewed by Cursor Bugbot for commit ba47833. Bugbot is set up for automated code reviews on this repo. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants