Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions src/core/browser.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
import { describe, it, expect, vi, beforeEach } from 'vitest'

const openMock = vi.fn<(...args: [string]) => Promise<unknown>>()

vi.mock('open', () => ({
default: (url: string) => openMock(url),
}))

import { openUrlSafe } from './browser.js'

describe('openUrlSafe', () => {
beforeEach(() => {
openMock.mockReset()
})

it('forwards url to open', () => {
openMock.mockResolvedValue(undefined)
const onError = vi.fn<(message: string) => void>()

openUrlSafe('https://www.pixelmuse.studio/g/gen_123', onError)

expect(openMock).toHaveBeenCalledWith('https://www.pixelmuse.studio/g/gen_123')
expect(onError).not.toHaveBeenCalled()
})

it('surfaces failures without throwing', async () => {
openMock.mockRejectedValue(new Error('No browser available'))
const onError = vi.fn<(message: string) => void>()

expect(() => {
openUrlSafe('https://www.pixelmuse.studio/g/gen_456', onError)
}).not.toThrow()

await Promise.resolve()
await Promise.resolve()

expect(onError).toHaveBeenCalledWith('No browser available')
})
})
7 changes: 7 additions & 0 deletions src/core/browser.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import open from 'open'

export function openUrlSafe(url: string, onError: (message: string) => void): void {
void open(url).catch((err: unknown) => {
onError(err instanceof Error ? err.message : 'Failed to open browser')
})
}
6 changes: 4 additions & 2 deletions src/screens/GalleryDetail.tsx
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import React, { useState, useEffect } from 'react'
import { Box, Text, useInput } from 'ink'
import { ConfirmInput, Spinner } from '@inkjs/ui'
import open from 'open'
import type { PixelmuseClient } from '../core/client.js'
import type { Generation } from '../core/types.js'
import { openUrlSafe } from '../core/browser.js'
import { imageToBuffer, autoSave } from '../core/image.js'
import ImagePreview from '../components/ImagePreview.js'

Expand Down Expand Up @@ -49,7 +49,9 @@ export default function GalleryDetail({ client, generationId, back }: Props) {
if (confirming) return
if (input === 'd') setConfirming(true)
if (input === 'o' && generation) {
open(`https://www.pixelmuse.studio/g/${generation.id}`)
openUrlSafe(`https://www.pixelmuse.studio/g/${generation.id}`, (message) => {
setError(message)
})
}
})

Expand Down
Loading