fix: prevent delete-generation failures on 204 responses#32
Draft
cursor[bot] wants to merge 1 commit intomainfrom
Draft
fix: prevent delete-generation failures on 204 responses#32cursor[bot] wants to merge 1 commit intomainfrom
cursor[bot] wants to merge 1 commit intomainfrom
Conversation
Co-authored-by: Dylan Boudro <starmorph@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
204 No Contentresponses were treated as JSON and threw parse errors.deleteGeneration) despite backend success, causing major user-facing breakage in gallery delete actions.Root cause
PixelmuseClient.request()unconditionally calledres.json()for all successful responses. The API documentsDELETE /api/v1/images/{id}returning204, which has no body.Fix
src/core/client.ts, returnundefinedfor204/205before JSON parsing.src/core/client.test.tsvalidating thatdeleteGeneration()succeeds when fetch returns 204.Validation
pnpm buildpnpm test(all tests passing, including new regression test)