[markerTagToScene] add all marker tags to scene not just primary#155
Closed
stg-annon wants to merge 3 commits intostashapp:mainfrom
Closed
[markerTagToScene] add all marker tags to scene not just primary#155stg-annon wants to merge 3 commits intostashapp:mainfrom
stg-annon wants to merge 3 commits intostashapp:mainfrom
Conversation
looks at all marker tags from `SceneMarkerUpdateInput` and compares them to existing scene `tag_ids` adds any tags that are missing from scene
Contributor
Author
|
so js plugins seem to have an issue with arrow functions as well as some other issues I'm unfamiliar with, I could rewrite this in python but I'm not sure that is the ideal solution here so I will draft a PF for it if it is not wanted feel free to close it |
bumps version to 2.0 as language change here is somewhat significant
Contributor
|
following. it works with this merge request with no issues |
Collaborator
|
@stg-annon sorry for the late review |
Contributor
Author
Contributor
|
@stg-annon still feel the same way? This has sat a while and between this and #154 , and #152. i think one of these go in, or some hybrid approach. Preference? |
Contributor
Author
|
this would be easy for me to maintain but I don't love introducing requirements where I don't have to, if |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
looks at all marker tags from
SceneMarkerUpdateInputand compares them to existing scenetag_idsadds any tags that are missing from scene