Fix issue_253: clear nested defer queue on sub-state-machine exit#8
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes boost-ext#253 by ensuring deferred events belonging to a nested sub-state-machine don’t leak across sub-SM exit/re-entry, and adds a focused functional test to prevent regressions.
Changes:
- Add a new FT regression test validating that nested sub-SM deferred events are cleared on exit/re-entry.
- Update composite-state initialization to recurse into nested composite sub-state-machines.
- Clear a sub-state-machine’s defer queue and reset its defer-processing state when transitioning out of that sub-state-machine.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
include/boost/sml.hpp |
Adds defer-queue clearing + defer-processing reset on sub-SM exit; recurses composite initialization. |
test/ft/issue_253.cpp |
New regression test reproducing issue boost-ext#253 and validating fixed behavior. |
test/ft/CMakeLists.txt |
Registers the new test_issue_253 executable/test with CTest. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_issue_253) reproducing and validating the original issueDetails
Validation
./scripts/quality_gates.sh