fix: improve convergence speed and robustness in EM estimation (#1)#2
Open
TianzhuQin wants to merge 6 commits into
Open
fix: improve convergence speed and robustness in EM estimation (#1)#2TianzhuQin wants to merge 6 commits into
TianzhuQin wants to merge 6 commits into
Conversation
Add gsynth callout tip, link gsynth/panelView user manuals, fix table alignment and minor formatting. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add warm-start CV loop reusing fitted values across r/lambda candidates - Preserve burn-in progress in weighted IFE estimation (remove Y0 reset) - Add multi-start initialization via perturbedFit() and n.init parameter - Add convergence diagnostics: converged flag in C++ + R-level warning - Update man/fect.Rd for n.init parameter, add rnorm to NAMESPACE All 586 existing tests pass. Default behavior (n.init=1) is numerically identical to previous version. Fixes #1
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…reps) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1 — convergence speed and robustness improvements for the EM-based estimation pipeline.
Changes
R/cv.R): Reuses fitted values from previous r/lambda candidate as starting pointsrc/ife_sub.cpp): Retains converged burn-in solution instead of resetting to Y0R/support.R,R/cv.R,R/default.R): Newn.initparameter for robustnesssrc/ife_sub.cpp,src/ife.cpp,R/cv.R,R/fe.R):convergedflag + R-level warningBackward Compatibility
Default behavior (
n.init = 1) is numerically identical to previous version.Validation
Generated by StatsClaw automated workflow.