allow nil in class and remove it#1
Open
jbswetnam wants to merge 1 commit intostch-library:masterfrom
jbswetnam:nil-classes
Open
allow nil in class and remove it#1jbswetnam wants to merge 1 commit intostch-library:masterfrom jbswetnam:nil-classes
jbswetnam wants to merge 1 commit intostch-library:masterfrom
jbswetnam:nil-classes
Conversation
explain nil classes in README remove empty string, set, seq from class forgot to add clojure to code markdown correction and enhancement to README remove irrelevant examples from README
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Great library! Just stumbled on it today, and I like the approach. One additional feature that I would like to have is the ability to set the class of an element conditionally without unwanted spaces or an empty class attribute.
This update allows that:
I did not change the cljs source because I don't know how to run the tests for it (still new at cljs). I'd be happy to update it if you can tell me how to run the tests!