-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
bench: refactor to use string interpolation in ndarray/base
#11437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kgryte
merged 10 commits into
stdlib-js:develop
from
anandkaranubc:bench/ndarray-base-format8
May 20, 2026
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b5246f5
bench: refactor to use string interpolation in `@stdlib/ndarray/base`…
anandkaranubc 40380a4
Merge branch 'develop' into bench/ndarray-base-format8
anandkaranubc e1a7fb7
Merge branch 'develop' into bench/ndarray-base-format8
anandkaranubc dd19fb4
bench: refactor to use string interpolation in `@stdlib/ndarray/base`…
anandkaranubc a8534bf
Merge branch 'develop' into bench/ndarray-base-format8
anandkaranubc 7cdc97d
bench: pass `isRowMajor` in unary/unary-by benchmarks
anandkaranubc db5f38e
chore: fix JavaScript lint errors
anandkaranubc a92cacf
chore: fix JavaScript lint errors
anandkaranubc 8e1600d
chore: fix JavaScript lint errors
anandkaranubc ff06ad5
Merge branch 'develop' into bench/ndarray-base-format8
anandkaranubc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kgryte
Are we also updating patterns like these to
bench( format( '%s::base:ndims=2', pkg ), ... )?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, ideally. Some descriptions should use parameterization, rather than namespacing. This is an example of such a case.
This is where having plot support would be useful, as such patterns would be more evident based on visualization faceting. Sigh.