docs: fix description and return annotations in new ndarray/base/*-like packages#12145
Draft
Planeshifter wants to merge 2 commits into
Draft
docs: fix description and return annotations in new ndarray/base/*-like packages#12145Planeshifter wants to merge 2 commits into
ndarray/base/*-like packages#12145Planeshifter wants to merge 2 commits into
Conversation
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up fixes for commits merged to
developbetween 2026-05-14 18:46 UTC and 2026-05-15 11:20 UTC (commit rangeb517ce1..f0ed784, 21 commits reviewed). A post-merge review found two newly added packages carrying documentation defects:ndarray/base/falses-like: Fix documentation defects introduced in2dcfa84— removed Markdown backticks from thedescriptionfield inpackage.json(plain text, per convention inndarray/base/falsesandndarray/base/nulls-like) and corrected the@returnstag indocs/types/index.d.tsfromfilled ndarrayto`false`-filled arrayto match the value-qualified convention used across sibling packages.ndarray/base/trues-like: Fix documentation defects introduced in2e5a8c9— removed Markdown backticks from thedescriptionfield inpackage.json(plain-text convention, perndarray/base/truesandndarray/base/nulls-like) and corrected the@returnstag indocs/types/index.d.tsfromfilled ndarrayto`true`-filled arrayto match the value-qualified convention used byzeros-likeandnulls-like.Each package's fixes are committed separately.
Related Issues
None.
Questions
No.
Other
Scope. All 21 commits merged to
develop(first-parent) between 2026-05-14 18:46 UTC and 2026-05-15 11:20 UTC — a union diff of ~4900 insertions across 125 files: newndarray/base/{falses,trues,nulls}-likepackages,ndarray/base/{falses,trues}generic-dtype support,ndarray/base/{reverse,to-reversed}test/benchmark updates,ml/base/kmeans/algorithm-resolve-{str,enum}, theblas/base/dgemmresolveStrrefactor, and bot-generated docs/declaration commits.Validation performed.
docs/style-guidesand compared against established reference packages (ndarray/base/zeros-like,ndarray/base/nans-like,blas/base/transpose-operation-resolve-str, and the parentndarray/base/{falses,trues}packages). Only the twopackage.json/.d.tsdeviations above were confirmed.falses-like/trues-like/nulls-likefill values, the kmeans resolvers, and thedgemmresolveStrrefactor are all correct.Deliberately excluded. Subjective suggestions, style preferences not mandated by the guide, "might-be" problems, and anything requiring changes outside the reviewed diff window to validate. Bot-generated namespace/TOC/declaration commits were noted but not modified.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This pull request was authored by Claude Code as part of an automated post-merge review of commits merged to
developover the preceding 24 hours. Claude enumerated the commit range, ran a multi-agent style-compliance and bug/security review, validated each finding against established reference packages anddocs/style-guides, and applied the documentation fixes. Changes should be independently audited before merge.@stdlib-js/reviewers
Generated by Claude Code