Skip to content

chore: follow-up fixes for commits merged to develop on 2026-05-19 / 2026-05-20#12217

Draft
Planeshifter wants to merge 3 commits into
developfrom
philipp/fix-commit-review-2026-05-20
Draft

chore: follow-up fixes for commits merged to develop on 2026-05-19 / 2026-05-20#12217
Planeshifter wants to merge 3 commits into
developfrom
philipp/fix-commit-review-2026-05-20

Conversation

@Planeshifter
Copy link
Copy Markdown
Member

Description

Follow-up fixes for commits merged to develop between 9559de0 (2026-05-19 18:52 -0400) and 8c6dabd (2026-05-20 03:14 -0700).

Three high-signal issues across the ndarray/base namespace:

@stdlib/ndarray/base/order

  • Fixes a regression introduced in 10442350 (lib/node_modules/@stdlib/ndarray/base/order/lib/main.js) where unambiguously row-major strides (o === 1) were incorrectly coalesced with the ambiguous o === 3 branch and returned DEFAULT_ORDER, causing strictly row-major ndarray-likes to be misreported as column-major when defaults.order was set to 'column-major'; the branches are now split so o === 1 returns ROW_MAJOR, o === 2 returns COLUMN_MAJOR, and only o === 3 falls back to DEFAULT_ORDER.

@stdlib/ndarray/base/ndarraylike2descriptor

  • Fix API heading in lib/node_modules/@stdlib/ndarray/base/ndarraylike2descriptor/README.md (cba1074): ndarraylike2descriptor takes a single ndarray-like argument x, not the descriptor field list ( dtype, buffer, shape, strides, offset, order ) copied from the descriptor() factory signature; corrected to #### ndarraylike2descriptor( x ) to match the d.ts, repl.txt, and the README's own Parameters section.

@stdlib/ndarray/base (namespace TOC)

  • Fix ndarraylike2descriptor TOC signature in lib/node_modules/@stdlib/ndarray/base/README.md (71da5f4): the namespace entry incorrectly listed the full descriptor() factory parameters ( dtype, buffer, shape, strides, offset, order ) rather than the actual single-argument signature ( x ).

Related Issues

None.

Questions

No.

Other

Validation

Reviewed the 37 commits merged to develop in the window for:

  • stdlib JavaScript / Markdown style-guide compliance (two independent passes)
  • objective bugs in the introduced code (two independent passes — diff-only)
  • incomplete renames across the isAlmostSameValue*isAlmostSame* family
  • signature / type / example consistency across new packages (assert/is-ndarray-descriptor, ndarray/base/ndarraylike2descriptor, blas/base/ndarray/gnrm2, stats/base/ndarray/dvariance, assert/is-almost-same-*)
  • descriptor() argument-order consistency across the unary-reduce / unary-strided refactor
  • benchmark format() placeholder/argument-count parity across the ndarray/base interpolation sweep

Deliberately excluded:

  • Copyright-year deltas on renamed assert/is-almost-same-* packages (every file in those packages carries 2025 because the rename copied content from packages originally created in 2025; bumping copyright on a rename is not stdlib practice and would expand scope)
  • is-ndarray-descriptor's loose hasProp(v, 'dtype') check (intentional per the inline comment on lib/main.js:54: dtypes may be strings, objects, or other)
  • Any finding that required code outside the diff window to validate

Checklist

AI Assistance

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was authored by Claude Code on behalf of @Planeshifter as an automated follow-up review of commits merged to develop over the last 24 hours. Findings were produced by parallel reviewer agents, de-duplicated and re-verified against the diff before commits were applied. A human will audit and promote the PR out of draft.


@stdlib-js/reviewers


Generated by Claude Code

claude added 3 commits May 20, 2026 12:23
…y/base/order`

When `strides2order` returns `1`, the strides are unambiguously row-major
and should yield `'row-major'` regardless of the configured default order.
Only the `o === 3` "both row- and column-major" case is ambiguous and
should fall back to the default.
The function takes a single ndarray-like argument; the heading was
showing the descriptor field list instead of the actual parameter.
…ace TOC

The TOC entry showed the descriptor field list as the argument list;
the function takes a single ndarray-like argument.
@stdlib-bot
Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
ndarray/base $\color{red}177246/348012$
$\color{green}+50.93%$
$\color{red}1926/1955$
$\color{green}+98.52%$
$\color{red}20/1721$
$\color{green}+1.16%$
$\color{red}177246/348012$
$\color{green}+50.93%$
ndarray/base/ndarraylike2descriptor $\color{green}100/100$
$\color{green}+100.00%$
$\color{green}3/3$
$\color{green}+100.00%$
$\color{green}1/1$
$\color{green}+100.00%$
$\color{green}100/100$
$\color{green}+100.00%$
ndarray/base/order $\color{green}132/132$
$\color{green}+100.00%$
$\color{green}14/14$
$\color{green}+100.00%$
$\color{green}1/1$
$\color{green}+100.00%$
$\color{green}132/132$
$\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants