chore: follow-up fixes for commits merged to develop on 2026-05-19 / 2026-05-20#12217
Draft
Planeshifter wants to merge 3 commits into
Draft
chore: follow-up fixes for commits merged to develop on 2026-05-19 / 2026-05-20#12217Planeshifter wants to merge 3 commits into
develop on 2026-05-19 / 2026-05-20#12217Planeshifter wants to merge 3 commits into
Conversation
…y/base/order` When `strides2order` returns `1`, the strides are unambiguously row-major and should yield `'row-major'` regardless of the configured default order. Only the `o === 3` "both row- and column-major" case is ambiguous and should fall back to the default.
The function takes a single ndarray-like argument; the heading was showing the descriptor field list instead of the actual parameter.
…ace TOC The TOC entry showed the descriptor field list as the argument list; the function takes a single ndarray-like argument.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up fixes for commits merged to
developbetween9559de0(2026-05-19 18:52 -0400) and8c6dabd(2026-05-20 03:14 -0700).Three high-signal issues across the
ndarray/basenamespace:@stdlib/ndarray/base/orderlib/node_modules/@stdlib/ndarray/base/order/lib/main.js) where unambiguously row-major strides (o === 1) were incorrectly coalesced with the ambiguouso === 3branch and returnedDEFAULT_ORDER, causing strictly row-major ndarray-likes to be misreported as column-major whendefaults.orderwas set to'column-major'; the branches are now split soo === 1returnsROW_MAJOR,o === 2returnsCOLUMN_MAJOR, and onlyo === 3falls back toDEFAULT_ORDER.@stdlib/ndarray/base/ndarraylike2descriptorlib/node_modules/@stdlib/ndarray/base/ndarraylike2descriptor/README.md(cba1074):ndarraylike2descriptortakes a single ndarray-like argumentx, not the descriptor field list( dtype, buffer, shape, strides, offset, order )copied from thedescriptor()factory signature; corrected to#### ndarraylike2descriptor( x )to match the d.ts, repl.txt, and the README's own Parameters section.@stdlib/ndarray/base(namespace TOC)ndarraylike2descriptorTOC signature inlib/node_modules/@stdlib/ndarray/base/README.md(71da5f4): the namespace entry incorrectly listed the fulldescriptor()factory parameters( dtype, buffer, shape, strides, offset, order )rather than the actual single-argument signature( x ).Related Issues
None.
Questions
No.
Other
Validation
Reviewed the 37 commits merged to
developin the window for:isAlmostSameValue*→isAlmostSame*familyassert/is-ndarray-descriptor,ndarray/base/ndarraylike2descriptor,blas/base/ndarray/gnrm2,stats/base/ndarray/dvariance,assert/is-almost-same-*)descriptor()argument-order consistency across theunary-reduce/unary-stridedrefactorformat()placeholder/argument-count parity across thendarray/baseinterpolation sweepDeliberately excluded:
assert/is-almost-same-*packages (every file in those packages carries 2025 because the rename copied content from packages originally created in 2025; bumping copyright on a rename is not stdlib practice and would expand scope)is-ndarray-descriptor's loosehasProp(v, 'dtype')check (intentional per the inline comment onlib/main.js:54: dtypes may be strings, objects, or other)Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code on behalf of @Planeshifter as an automated follow-up review of commits merged to
developover the last 24 hours. Findings were produced by parallel reviewer agents, de-duplicated and re-verified against the diff before commits were applied. A human will audit and promote the PR out of draft.@stdlib-js/reviewers
Generated by Claude Code