fix: correct typos and errors in blas/ext/base/dediff#12228
Draft
Planeshifter wants to merge 1 commit into
Draft
fix: correct typos and errors in blas/ext/base/dediff#12228Planeshifter wants to merge 1 commit into
blas/ext/base/dediff#12228Planeshifter wants to merge 1 commit into
Conversation
Corrects documentation typos in the README and REPL help text, removes a stray argument from the C API usage example, removes an extraneous tab in the TypeScript declaration, fixes comment misspellings and a missing argument in the declaration tests, replaces duplicated argument-count test stubs, and fixes test description grammar.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up fixes for commits merged to
developbetween 2026-05-20 12:04 and 2026-05-20 21:06 (PDT).This pull request is the output of an automated review of the 18 commits merged to
developin that window (24639c346…e1dd43fdd). Every validated, high-signal issue was grouped by package and committed separately. All findings landed in a single package —blas/ext/base/dediff, added ine46390e26:blas/ext/base/dediffappendparameter description inREADME.md(differences..→differences.). [e46390e26]strideAparameter description inREADME.md: three occurrences read "strides length" (plural) — one in the JS API list and two in the C API lists — inconsistent with the singular "stride length" used by every other stride parameter; changed all three. [e46390e26]stdlib_strided_dediff_ndarrayC usage example inREADME.md, which passed 16 arguments — a stray1immediately afterN— for a 15-parameter function; removed the stray argument to match the signature and the siblingsediffexample. [e46390e26]ooparameter indocs/repl.txt, documented as "Stride length forOut" (a copy of thesostride entry); it is the output starting index, so changed it to "Starting index forOut". [e46390e26]ndarraymethod name and its parameter list in the interface declaration indocs/types/index.d.ts. [e46390e26]docs/types/test.ts. [e46390e26]docs/types/test.ts. [e46390e26]$ExpectType) declaration test fordediff.ndarrayindocs/types/test.ts, which passed only 14 arguments and omitted the required finaloffsetOut; added the missing argument to match the 15-parameter signature. [e46390e26]ndarray"unsupported number of arguments"$ExpectErrorblock indocs/types/test.ts, which left the 4-, 8-, and 12-argument cases untested; the block now steps through every arity, consistent with the siblingsediffandddifftest files. [e46390e26]dedifftest files (test/test.dediff.js,test.ndarray.js,test.dediff.native.js,test.ndarray.native.js). [e46390e26]t.strictEqualassertion messages across the fourdedifftest files from "return expected value" to "returns expected value", matching the adjacentt.deepEqualmessages. [e46390e26]Related Issues
None.
Questions
No.
Other
Validation
Reviewed: all 18 commits merged to
developin the window (24639c346…e1dd43fdd), via the union diff and per-commit diffs. Four independent review passes were run — two stdlib code-style compliance audits (changed code compared against the established sibling packagesddiff/sdiff/gdiffand the guidelines underdocs/style-guides), one diff-only bug scan, and one correctness/security pass over the introduced code (C source, JS lib, declarations, tests).Checked:
dediff,sediff,zdiff), plus thendarray/base/orderlogic fix.format(...)refactor (~80 files) for specifier/argument mismatches — none found.Deliberately excluded:
X[offsetX]read in the newdediff/sediffC*_ndarrayroutines whenN == 0— was dropped.N == 0is not a valid input under the package'sN + N1 + N2 - 1output-size contract, the second bug reviewer cleared the same code, and a complete fix would require redesigning the package, outside the scope of this window's diff.This PR is intentionally left in draft for a maintainer to audit and promote.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This pull request was produced end-to-end by an automated Claude Code review routine. Claude enumerated the 24-hour commit window on
develop, ran four independent review passes, validated every finding against the affected files and sibling packages, applied the fixes, and drafted this description. All changes are mechanical typo, documentation, and test corrections confined to a single package. A human maintainer should audit before promoting from draft.@stdlib-js/reviewers
Generated by Claude Code