style(@stdlib/blas/base/drotm): fix spacing in multiline xe/ye arrays#12230
Draft
Planeshifter wants to merge 1 commit into
Draft
style(@stdlib/blas/base/drotm): fix spacing in multiline xe/ye arrays#12230Planeshifter wants to merge 1 commit into
Planeshifter wants to merge 1 commit into
Conversation
The lint workflow on develop (run 26197800347) reported 40 errors in `test/test.ndarray.js`: 20 `eol-open-bracket-spacing` and 20 `line-closing-bracket-spacing` violations. The multiline expected-value arrays xe and ye used `new Float64Array( [` and `] )` with spaces, which the stdlib ESLint rules disallow when array content spans multiple lines. Input arrays x and y in the same file already used the correct no-space format. This commit aligns xe and ye with that established pattern. Ref: https://github.com/stdlib-js/stdlib/actions/runs/26197800347
stdlib-bot
added
BLAS
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #12222.
Description
This pull request:
@stdlib/blas/base/drotmtest/test.ndarray.jsreported by the lint CI workflow (run 26197800347) on thedevelopbranchThe violations were:
stdlib/eol-open-bracket-spacingerrors — multilinexe/yeexpected-value arrays usednew Float64Array( [(space before[at end of line), which the rule disallowsstdlib/line-closing-bracket-spacingerrors — the corresponding closing lines used] );(space before)at start of line), which the companion rule disallowsThe fix removes the spaces so the bracket style matches the
x/yinput arrays already present in the same file, which already used the correct no-space multiline form.Note for reviewers: Three sibling test files (
test.drotm.js,test.drotm.native.js,test.ndarray.native.js) contain approximately 60 identical latent violations using the same wrong pattern. Those files are out of scope for this PR but may be worth addressing in a follow-up.Related Issues
This pull request has the following related issues:
Questions
No.
Other
CI workflow run that surfaced the failures: https://github.com/stdlib-js/stdlib/actions/runs/26197800347
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code. An automated CI-fix routine identified the lint failures from issue #12222, read the ESLint rule source to confirm the correct bracket-spacing semantics for multiline arrays, applied a targeted regex substitution to remove only the 40 offending spaces in the xe/ye expected-value arrays, and validated the change via three independent review passes before committing.
@stdlib-js/reviewers
Generated by Claude Code