feat: add ml/base/sgd-classification/loss-functions#13333
feat: add ml/base/sgd-classification/loss-functions#13333nakul-krishnakumar wants to merge 3 commits into
ml/base/sgd-classification/loss-functions#13333Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: passed
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: passed
- task: lint_repl_help
status: passed
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: passed
- task: lint_license_headers
status: passed
---
Coverage Report
The above coverage report was generated for the changes in this PR. |
There was a problem hiding this comment.
Sorry to be pedantic, but would you mind ordering in alphabetical order? This helps with visual scanning. Namely, it is easier for a reader to scan a sorted list than it is an unsorted list.
There was a problem hiding this comment.
This will impact all the docs and tests in this package.
There was a problem hiding this comment.
Sure, will do 👍
There was a problem hiding this comment.
Sanity check. For these types of things, do we have any precedent for using camelcase rather than kebabcase?
There was a problem hiding this comment.
I.e., epsilonInsensitive vs epsilon-insensitive
There was a problem hiding this comment.
https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/ml/incr/binary-classification#:~:text=loss,Default%3A%20%27log%27%2E

I would be happy to switch to kebabcase
There was a problem hiding this comment.
Here is another example where we use kebabcase: https://github.com/stdlib-js/stdlib/tree/refactor/plot/lib/node_modules/%40stdlib/plot/vega/mark/interpolation-methods
In short, I think ml/incr/binary-classification is the odd one out here and we should make a breaking change in that package to use kebabcase for the option values.
You in agreement?
There was a problem hiding this comment.
Feel free to either open a PR making the change on that package, or, at minimum, opening an issue so we don't forget to make the change.
There was a problem hiding this comment.
Yes I completely agree with you here.
So as mentioned above I will be refactoring the enum in this package from camelcase to kebabcase, after which I will raise a PR to do the same for ml/incr/binary-classification. 🚀
There was a problem hiding this comment.
I noticed that ml/incr/sgd-regression also follows camelcase for loss functions. I will open an issue mentioning both the packages.
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: passed
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: passed
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: passed
- task: lint_license_headers
status: passed
---
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: passed
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: passed
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: passed
- task: lint_license_headers
status: passed
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Resolves a part of #12875.
Description
This pull request:
ml/base/sgd-classification/loss-functions.Related Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers