chore(regexp): add missing match keyword to regexp and extended-length-path#13351
Draft
Planeshifter wants to merge 2 commits into
Draft
chore(regexp): add missing match keyword to regexp and extended-length-path#13351Planeshifter wants to merge 2 commits into
match keyword to regexp and extended-length-path#13351Planeshifter wants to merge 2 commits into
Conversation
Adds the `match` keyword to `@stdlib/regexp/regexp/package.json`. The keyword is present in 23 of 27 sibling packages (85.2%) — all sibling regex-producer packages that describe a match target carry it. The package's own JSDoc summary reads "regular expression to parse a regular expression string", i.e. it matches regex-literal syntax; the absent keyword contradicts that description.
Adds the `match` keyword to `@stdlib/regexp/extended-length-path/package.json`. The keyword is present in 23 of 27 sibling packages (85.2%). The package's own `main.js` describes returning a regular expression that matches an extended-length Windows path; the absent keyword contradicts that description.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the missing
matchkeyword to@stdlib/regexp/regexp/package.jsonand@stdlib/regexp/extended-length-path/package.json. The keyword is present in 23 of 27 sibling packages under@stdlib/regexp/*(85.2%); these two were the only regex-producing outliers. The two remaining packages without it —reviverandto-json— legitimately lack it since neither performs a match:reviverdeserializes a JSON representation into aRegExpinstance andto-jsonserializes aRegExpin the opposite direction.regexp/regexpThe package's own JSDoc summary reads "regular expression to parse a regular expression string" — it matches regex-literal syntax. The absent keyword contradicts that description.
regexp/extended-length-pathThe package's own
main.jsreturns a regular expression that matches extended-length Windows paths. The absent keyword contradicts that description.Related Issues
This pull request has no related issues.
Questions
No.
Other
The change was produced by an automated cross-package drift audit over the 27 non-autogenerated members of
@stdlib/regexp/*. Three independent reviewer agents (semantic, cross-reference, structural) confirmed both corrections. Total diff is 3 LOC across 2 files.No other drift corrections survived filtering. Outliers dropped as intentional deviations:
reviverandto-jsonmissingtest/test.main.js(theirmain.jsis the tested function, no separate factory to exercise);color-hexadecimalinlining regex constants inlib/index.jsrather than following thelib/regexp.jsconvention (74.07% sibling conformance — below the 75% majority threshold; three-constant split has no clean sibling analog). Missing## See Alsosections in five packages were skipped as auto-populated by the package generator.Only the in-repo consumer of
package.jsonkeywordsis the_tools/search/pkg-indexfull-text index (bag-of-words, order-independent), so keyword insertion position is not observable to downstream tooling.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code as part of an automated cross-package drift detection routine over
@stdlib/regexp/*. Three independent reviewer agents (semantic, cross-reference, structural) confirmed each candidate before the fixes were applied. A maintainer should promote out of draft after review.@stdlib-js/reviewers
Generated by Claude Code