Skip to content

build(workflows): skip stale msvs_version npm config on Node.js v18/v20 #13411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Planeshifter wants to merge 1 commit into
base: develop
Choose a base branch
from
+12 −0
Draft

build(workflows): skip stale msvs_version npm config on Node.js v18/v20 #13411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/windows_test_npm_install.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,19 @@ jobs:
timeout-minutes: 5

# Configure npm:
#
# ## Notes
#
# - `msvs_version` is a legacy `node-gyp` hint key. npm v10+ (used by
# Node.js v18 and v20 per `NPM_VERSION: '>10.0.0'` above) validates
# `npm config set` keys against a fixed schema and rejects
# unrecognized keys, so this step is skipped for those versions.
# Older npm releases accept the key without validation, and
# `node-gyp` bundled with npm v10+ auto-detects the installed
# Visual Studio toolset via `vswhere`, so the hint is unnecessary
# there.
- name: 'Configure npm'
if: matrix.NODE_VERSION != '20' && matrix.NODE_VERSION != '18'
run: |
. "${{ env.NVS_HOME }}/nvs.sh" && nvs use ${{ matrix.NODE_VERSION }}
npm config set msvs_version 2019
Expand Down