feat: add iter/cartesian-square#1371
Closed
vinayak-00017 wants to merge 4 commits into
Closed
Conversation
stdlib-bot
reviewed
Feb 24, 2024
Contributor
stdlib-bot
left a comment
stdlib-bot
left a comment
There was a problem hiding this comment.
👋 Hi there! 👋
And thank you for opening your first pull request! We will review it shortly. 🏃 💨
kgryte
added
Feature
kgryte
changed the title
iter/cartesian-square
Signed-off-by: vinayak <fobo401@gmail.com>
kgryte
reviewed
Feb 25, 2024
kgryte
reviewed
Feb 25, 2024
kgryte
reviewed
Feb 25, 2024
kgryte
reviewed
Feb 25, 2024
kgryte
reviewed
Feb 25, 2024
kgryte
reviewed
Feb 25, 2024
kgryte
reviewed
Feb 25, 2024
kgryte
reviewed
Feb 25, 2024
kgryte
reviewed
Feb 25, 2024
kgryte
reviewed
Feb 25, 2024
kgryte
reviewed
Feb 25, 2024
kgryte
reviewed
Feb 25, 2024
kgryte
reviewed
Feb 25, 2024
kgryte
reviewed
Feb 25, 2024
kgryte
reviewed
Feb 25, 2024
kgryte
reviewed
Feb 25, 2024
kgryte
added
Needs Changes
…with the package Signed-off-by: vinayak <fobo401@gmail.com>
…with package Signed-off-by: vinayak <fobo401@gmail.com>
Author
|
I have made the changes you mentioned. Thanks for the review. |
Planeshifter
requested changes
Mar 17, 2024
Member
Planeshifter
left a comment
Planeshifter
left a comment
There was a problem hiding this comment.
The tests currently won't run in environments lacking Symbol.iterator support. See the tests for other iterator packages such as https://github.com/stdlib-js/stdlib/blob/develop/lib/node_modules/%40stdlib/iter/head/test/test.js for how to ensure that tests can run in older environments lacking Symbols. This is currently blocking merging this PR.
Member
|
@vinayak-00017 Are you still interested in working on this PR? |
Author
I apologise, I might not be able to complete it. |
stdlib-bot
added
the
Potential Duplicate
Closed
stdlib-bot
removed
the
Potential Duplicate
kgryte
added
the
autoclose: Stale
Contributor
|
This pull request has been automatically closed because it has been inactive for an extended period after changes were requested. If you still wish to pursue this contribution, feel free to reopen the pull request or submit a new one. We appreciate your interest in contributing to stdlib! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1334 .
Description
This pull request:
Related Issues
This pull request:
@stdlib/iter/cartesian-square#1334Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers