refactor: implement stealth cli as rust crate #18
Open
satsfy wants to merge 2 commits intostealth-bitcoin:mainfrom
Open
refactor: implement stealth cli as rust crate #18satsfy wants to merge 2 commits intostealth-bitcoin:mainfrom
satsfy wants to merge 2 commits intostealth-bitcoin:mainfrom
Conversation
satsfy
force-pushed
the
add-cli
branch
2 times, most recently
from
b2da99c to
d4fe31f
Compare
Collaborator
Author
|
@LORDBABUINO fyi this is rebased and ready for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #16 (it will be in draft mode until its merged)
This PR is a combination of rust refactors from @brenorb in #15 and me.
Implements a CLI crate (
stealth-cli) that can scan a single descriptor, multiple descriptors from a file, or raw UTXOs, with text/json output modes.Add instructions on README on how to use the CLI.
Reviewer Notes
Run the CLI:
cargo run --bin stealth-cli -- scan \ --descriptor 'wpkh([f23f9fd2/84h/0h/0h]xpub.../0/*)' \ --rpc-url http://127.0.0.1:18443 \ --rpc-user localuser \ --rpc-pass localpass \ --format text