Remaining changes for libsphinx-less Androsphinx#16
Merged
stef merged 5 commits intostef:masterfrom Oct 11, 2025
Merged
Conversation
without this, Android cross-compile only works on hosts with SOEXT=.so
|
Owner
|
strange all of the makefile changes are already merged. only a couple jni.c changes are missing. i have a déja vu didn't i merge this already? |
Contributor
Author
You merged #15 but with a squash, and I continued work on my original branch instead of dropping mine and basing my work on your version of Git history. So yes, you merged part of it, and GitHub displayed the remaining bits correctly in the diff. |
stef
pushed a commit
that referenced
this pull request
Oct 15, 2025
* revert .so to SOEXT without this, Android cross-compile only works on hosts with SOEXT=.so * added experimental JNI bindings * JNI getInputSizes: return bool as well * moved generic libsodium JNI bindings from libsphinx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pwhashboolreturn value togetInputSizesalongside the array as it appears to be used as well