-
Notifications
You must be signed in to change notification settings - Fork 694
Reduce battery drain from OpenAI web extras #529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cbrane
wants to merge
8
commits into
steipete:main
Choose a base branch
from
cbrane:fix-battery-draining-issue
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5f90993
Reduce battery drain from OpenAI web extras
cbrane b6f4adc
Make OpenAI web refresh discoverable
cbrane fe9e18a
Merge remote-tracking branch 'origin/main' into fix-battery-draining-…
cbrane a563dba
Merge remote-tracking branch 'origin/main' into fix-battery-draining-…
cbrane f6ce9f6
Merge remote-tracking branch 'origin/main' into fix-battery-draining-…
cbrane 8343a6f
Separate OpenAI web extras from battery saver
cbrane 381498f
Respect battery saver on stale dashboard refresh
cbrane c53ad3e
Merge remote-tracking branch 'origin/main' into fix-battery-draining-…
cbrane File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| import CodexBarCore | ||
| import Foundation | ||
|
|
||
| @MainActor | ||
| extension UsageStore { | ||
| func clearDisabledProviderState(enabledProviders: Set<UsageProvider>) { | ||
| for provider in UsageProvider.allCases where !enabledProviders.contains(provider) { | ||
| self.refreshingProviders.remove(provider) | ||
| self.snapshots.removeValue(forKey: provider) | ||
| self.errors[provider] = nil | ||
| self.lastSourceLabels.removeValue(forKey: provider) | ||
| self.lastFetchAttempts.removeValue(forKey: provider) | ||
| self.accountSnapshots.removeValue(forKey: provider) | ||
| self.tokenSnapshots.removeValue(forKey: provider) | ||
| self.tokenErrors[provider] = nil | ||
| self.failureGates[provider]?.reset() | ||
| self.tokenFailureGates[provider]?.reset() | ||
| self.statuses.removeValue(forKey: provider) | ||
| self.lastKnownSessionRemaining.removeValue(forKey: provider) | ||
| self.lastKnownSessionWindowSource.removeValue(forKey: provider) | ||
| self.lastTokenFetchAt.removeValue(forKey: provider) | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick question: for someone who already had OpenAI Web Extras enabled before this setting existed, do we want them to land in Battery Saver automatically on upgrade, or is it worth checking whether their current refresh behavior should be preserved until they choose otherwise?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I intentionally kept existing users on the safe path here. Given how severe the battery regression was, I think defaulting
Battery Saverto on for upgrades is the right migration, even for users who previously had OpenAI Web Extras enabled.