fix: sidebar labels not appearing#91
Conversation
Below the breakpoint the label is screen-reader-only (icon rail stays accessible); at/above it the label is simply its default visible state. Applying sr-only one-directionally avoids relying on a not-sr-only override beating the base rule, which is order/cache fragile. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Codex review: needs real behavior proof before merge. Reviewed July 5, 2026, 12:08 PM ET / 16:08 UTC. Summary Reproducibility: no. high-confidence live reproduction was established in this read-only review. Source inspection shows the normal AppNav path still depends on the old responsive class, and the attached screenshot shows the reported missing-label state rather than a verified fix. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the small responsive-class fix only after visible browser proof shows labels at desktop width and confirms labels remain hidden below the breakpoint or in compact routes. Do we have a high-confidence way to reproduce the issue? No high-confidence live reproduction was established in this read-only review. Source inspection shows the normal AppNav path still depends on the old responsive class, and the attached screenshot shows the reported missing-label state rather than a verified fix. Is this the best way to solve the issue? Yes, the proposed direction is narrow and maintainable: make labels visible by default and apply AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning high; reviewed against 66523e1dcb32. Label changesLabel justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
Review history (1 earlier review cycle)
|
Now below the breakpoint the label is screen-reader-only (icon rail stays accessible) but at/above it the label is simply its default visible state. Applying sr-only one-directionally avoids relying on a not-sr-only override beating the base rule, which is order/cache fragile.