Skip to content

fix(metrics): send metrics=all for summary and aggregate#23

Open
doodaaatimmy-creator wants to merge 1 commit intosteipete:mainfrom
doodaaatimmy-creator:codex/metrics-default-all
Open

fix(metrics): send metrics=all for summary and aggregate#23
doodaaatimmy-creator wants to merge 1 commit intosteipete:mainfrom
doodaaatimmy-creator:codex/metrics-default-all

Conversation

@doodaaatimmy-creator
Copy link

Summary

  • add metrics=all by default for metrics summary
  • add metrics=all by default for metrics aggregate
  • keep the existing v2=true aggregate query intact
  • add focused client regression tests for both request shapes

Repro

eightctl metrics summary -v
eightctl metrics aggregate -v

Before this change, both endpoints could fail with:

{
  "errors": {
    "metrics": ["The metrics field is required."]
  }
}

Testing

go test ./internal/client

Closes #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

metrics summary and metrics aggregate fail with "metrics field is required"

1 participant