feat: add multi-token batch payment support to pool_pay#18
Merged
MarcusDavidG merged 2 commits intoJun 21, 2026
Conversation
Group payments by token across invoices and perform one transfer per token, enabling batch payment of invoices using different tokens in a single pool_pay call. Also fixes missing escrow release timestamp when an escrow invoice is fully funded via pool_pay. Closes stellar-sharpy#3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently
pool_payassumes all invoices share the same token. This change groups payments by token (using each invoice'stokens.get(0)as the payment token), performs one transfer per unique token, then distributes to individual invoices.Changes
lib.rs: Rewrotepool_payto group payments by token using aMap<Address, i128>before transferring. Also fixed a missing escrow release timestamp when an escrow invoice is fully funded viapool_pay(the escrow state key was never written, unlike the singlepayfunction).test.rs: Added 3 new tests —test_pool_pay_multi_token,test_pool_pay_multi_token_same_token_grouped, andtest_pool_pay_partial_multi_token— plus asetup_with_tokenshelper that registers Stellar asset contracts and mints tokens to the payer.Related issue
Closes #3